Arm backend: Add bfloat16 support to VGF backend.#20299
Open
Erik-Lundell wants to merge 2 commits into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20299
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
❌ 2 New Failures, 1 Unrelated Failure, 2 Unclassified FailuresAs of commit f015b75 with merge base da9158b ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Erik-Lundell
added
partner: arm
Erik-Lundell
added
help wanted
volkkov
reviewed
Jun 22, 2026
volkkov
left a comment
volkkov
left a comment
There was a problem hiding this comment.
Good improvement overall. One edge case: empty string vs null aren't treated the same downstream — might need a normalization step.
Collaborator
Author
Thanks for the comment volkkov, could you please be a bit more specific? I.e. which string |
Erik-Lundell
force-pushed
the
upstream-bf16-vgf
branch
from
0650cd0 to
cf8b909
Compare
- Add bf16 extension to default VgfCompileSpec - Handle bf16 in VGFSetup.sh - Needs bumping of Vulkan SDK to 1.4.350.0 to include VK_FORMAT_R16_SFLOAT_FPENCODING_BFLOAT16_ARM Initially tested with a single operator test of matmul. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I74b0c15b5a4f9194c437e8e69d2349e9c282878b
digantdesai
reviewed
Jun 23, 2026
digantdesai
left a comment
digantdesai
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I will let @SS-JIA stamp it due to the submodule update.
Collaborator
|
Hi @SS-JIA what do you think about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially tested with a single operator test of matmul.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani